Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set pyupgrade version #2756

Merged
merged 1 commit into from
Oct 13, 2023
Merged

chore: set pyupgrade version #2756

merged 1 commit into from
Oct 13, 2023

Conversation

agoose77
Copy link
Collaborator

When we invoke pyupgrade, it should be given the minimum Python version explicitly; it doesn't read pyproject.toml.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #2756 (e95bc2c) into main (f35878f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

jpivarski
jpivarski approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll merge this now.

@jpivarski jpivarski merged commit ea8de12 into main Oct 13, 2023
37 checks passed
@jpivarski jpivarski deleted the agoose77/chore-precommit-pyupgrade-min-version branch October 13, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoose77 @jpivarski